It’s not obvious to me how black on yellow is a mistake. It’s quite readable, the contrast is broad enough for clarity but not so broad the background overwhelms the foreground. Yellow’s a recommended “light” background for visually impaired people so the choice has precedance (although I confess that many other examples of it I’ve seen use a softer pastel yellow which is more comfortable).
The huge area of intense yellow (or any highly saturated color actually) is very jarring. The eyes get tired quickly. It's really a weird choice coming from a person who is apparently into visual communication.
Btw, I'm using a desktop PC with a large browser window. Maybe on a small mobile screen the problem is less apparent.
Sure, but "white" has a pretty similar effect, especially on modern high lumen screens. "Dark mode" is popular for a reason.
Personally, anecdotally, I find the black-on-yellow easier to work with than most sites' black-on-white. I just tested it with my screen at two or three brightness levels, and it was more comfortable than similar content against white. I'm over-sensitive to glare because my eyes lack pigment. I _think_ this makes me more susceptible to contrast issues (it certainly feels like it, but I am only n=1 and I've not done careful study). I'm open to being challenged on this but you'll have to come with broad audience data to contradict a lot of lived experience.
It's fair that you might not like the black-on-yellow; you might feel it's a poor branding choice; but I still contest that it's not "wrong" for any technical, perceptual reason.